Make jvm_import use java from resolved toolchain instead of host machine.
#1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@comius, mind checking if my toolchain usage is kosher? |
jin
force-pushed
the
jvm_import_use_toolchain
branch
from
81f613b
to
ee44215
Compare
fmeum
added a commit
to fmeum/rules_jvm_external
that referenced
this pull request
Feb 23, 2024
PR bazelbuild#1058 made the `jvm_import` actions use Java toolchains rather than host tools, but chose the runtime used to run `javac` instead of the runtime used to run build tools. The latter can be configured via `--tool_java_runtime_version` while the former is fixed in the Java compilation toolchain.
jin
pushed a commit
that referenced
this pull request
Feb 23, 2024
PR #1058 made the `jvm_import` actions use Java toolchains rather than host tools, but chose the runtime used to run `javac` instead of the runtime used to run build tools. The latter can be configured via `--tool_java_runtime_version` while the former is fixed in the Java compilation toolchain.
jin
added a commit
to jin/rules_jvm_external
that referenced
this pull request
Feb 23, 2024
These PRs aren't needed since the downstream Bazel build just needed to pass `--tool_java_runtime_version` on top of `--tool_java_language_version`. cc @fmeum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the AddJarManifestEntry jar used in the
jvm_importactions is executed with the jdk version set by the downstream project's language version (which was used to correctly build the jar itself), which resolves to the right toolchain, instead of using whatever@local_jdkresolves to.This fixes the case where the jar is built with a newer JDK version/lang level, but executed with an older runtime.
Unblocks Bazel's JDK 21 upgrade.
Fixes #895