Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum bazel version in the module file #1092

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

shs96c
Copy link
Collaborator

@shs96c shs96c commented Apr 4, 2024

No description provided.

@fmeum
Copy link
Contributor

fmeum commented Apr 4, 2024

The MODULE.bazel specific formatting has been unapplied here. Just curious, how did you format the module file?

@shs96c shs96c added this to the Release 6.1 milestone Apr 4, 2024
@shs96c
Copy link
Collaborator Author

shs96c commented Apr 5, 2024

I format the codebase using bazel run scripts:format which also applies a java code formatter too. We use a pinned buildifier, so whoever runs the script should get the same result. However, I suspect that my system buildifier is being used when I modify the file in IJ, which may be at a different version.

Copy link
Member

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to minimize the diff to the bazel_compatibility line, but that's a nit.

@shs96c shs96c merged commit b07b79c into bazelbuild:master Apr 5, 2024
8 checks passed
@shs96c shs96c deleted the specify-bazel-version branch April 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants