Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid reference in coursier.bzl #1119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix invalid reference in coursier.bzl #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion private/rules/coursier.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,7 +1364,7 @@ pinned_coursier_fetch = repository_rule(
doc = "Instructions to re-pin the repository if required. Many people have wrapper scripts for keeping dependencies up to date, and would like to point users to that instead of the default.",
),
"excluded_artifacts": attr.string_list(default = []), # only used for hash generation
"_workspace_label": attr.label(default = Label("@//does/not:exist")),
"_workspace_label": attr.label(default = Label("@@//does/not:exist")),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to support Bazel 5 and 6, so this will cause a regression there. I think we need to do something smart to figure out whether or not bzlmod is being used (not just checking the version number), and then Do The Right Thing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maven_bom.bzl file has a utility method to determine whether we're using bzlmod or not. We might want to lift that out into another file and depend on that.

},
implementation = _pinned_coursier_fetch_impl,
)
Expand Down