feat: Pass additional coursier cli options #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
requested changes
May 15, 2024
honnix
force-pushed
the
resolver-additional-options
branch
from
5f9e7f4
to
30eb9c8
Compare
honnix
commented
May 15, 2024
| @@ -338,6 +340,8 @@ def _maven_impl(mctx): | |||
| if mod.is_root: | |||
| repo["repin_instructions"] = install.repin_instructions | |||
|
|
|||
| repo["additional_coursier_options"] = repo.get("additional_coursier_options", []) + getattr(install, "additional_coursier_options", []) | |||
There was a problem hiding this comment.
I'm not very sure I'm doing the right thing, so please let me know if anything missed.
shs96c
approved these changes
May 17, 2024
| @@ -338,6 +340,8 @@ def _maven_impl(mctx): | |||
| if mod.is_root: | |||
| repo["repin_instructions"] = install.repin_instructions | |||
|
|
|||
| repo["additional_coursier_options"] = repo.get("additional_coursier_options", []) + getattr(install, "additional_coursier_options", []) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary use case this change tries to solve is passing down
--max-iterationsto coursier because the default value could be too small for certain artifacts.