Disable tests on ubuntu1804 that don't work with JDK11 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have migrated ubuntu1804 to use OpenJDK 11, because that's the default JDK for that distribution. During the migration I noticed that you have tests that fail with OpenJDK 11, so I recommend to disable them until they're fixed. For your reference, here's the log: https://buildkite.com/bazel/rules-jvm-external/builds/390#b676ef53-ae08-46ce-ae22-a2d4bc336479
jin
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have migrated ubuntu1804 to use OpenJDK 11, because that's the default JDK for that distribution.
During the migration I noticed that you have tests that fail with OpenJDK 11, so I recommend to
disable them until they're fixed.
For your reference, here's the log: https://buildkite.com/bazel/rules-jvm-external/builds/390#b676ef53-ae08-46ce-ae22-a2d4bc336479