Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support additional netrc lines for downloading pinned artifacts #394

Merged
merged 1 commit into from
Mar 11, 2020
Merged

support additional netrc lines for downloading pinned artifacts #394

merged 1 commit into from
Mar 11, 2020

Conversation

kevingessner
Copy link
Contributor

Fixes #393

jin
jin approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add something to the README too, please?

@kevingessner
Copy link
Contributor Author

Done! added a note about ~/.netrc too, which was already in code.

@kevingessner kevingessner requested a review from jin March 11, 2020 17:07
@jin jin merged commit 7f29105 into bazelbuild:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin jin jin approved these changes

@c-parsons c-parsons Awaiting requested review from c-parsons

@laurentlb laurentlb Awaiting requested review from laurentlb

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inject custom netrc lines for pinned installs in the workspace
3 participants
@kevingessner @jin @googlebot