use jq instead of python to format the pinned JSON (fixes #395) #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, pinning does work on Windows. We test them on CI here: rules_jvm_external/.bazelci/presubmit.yml Lines 85 to 101 in 7f29105 |
|
OK, green now on all platforms! |
jin
reviewed
Mar 19, 2020
| @@ -22,6 +22,7 @@ genquery( | |||
| "@testonly_testing//:com_google_code_findbugs_jsr305", | |||
| "@testonly_testing//:com_google_auto_value_auto_value_annotations_1_6_3", | |||
| "@testonly_testing//:com_google_auto_value_auto_value_annotations", | |||
| "@testonly_testing//:pin", | |||
There was a problem hiding this comment.
The pinned repo should not have the pin build target.
There was a problem hiding this comment.
testonly_testing isn't pinned (no maven_install_json), so it should have a :pin target to create the initial JSON. right?
Line 226 in 7f29105
jin
approved these changes
Mar 28, 2020
| @@ -22,6 +22,7 @@ genquery( | |||
| "@testonly_testing//:com_google_code_findbugs_jsr305", | |||
| "@testonly_testing//:com_google_auto_value_auto_value_annotations_1_6_3", | |||
| "@testonly_testing//:com_google_auto_value_auto_value_annotations", | |||
| "@testonly_testing//:pin", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatted output is consistent with python2's
json.tool. No changes are required to how rules_jvm_external is added in the workspace nor how :pin is run. I've tested on linux (centos) and OS X.I didn't add jq for windows because I wasn't sure if pinning worked for windows at all, and I can't test it. Should I add that as well?