-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use jq instead of python to format the pinned JSON (fixes #395) #396
Conversation
Yes, pinning does work on Windows. We test them on CI here: rules_jvm_external/.bazelci/presubmit.yml Lines 85 to 101 in 7f29105
|
OK, green now on all platforms! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -22,6 +22,7 @@ genquery( | |||
"@testonly_testing//:com_google_code_findbugs_jsr305", | |||
"@testonly_testing//:com_google_auto_value_auto_value_annotations_1_6_3", | |||
"@testonly_testing//:com_google_auto_value_auto_value_annotations", | |||
"@testonly_testing//:pin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pinned repo should not have the pin build target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testonly_testing
isn't pinned (no maven_install_json), so it should have a :pin
target to create the initial JSON. right?
Line 226 in 7f29105
name = "testonly_testing", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you're right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
@@ -22,6 +22,7 @@ genquery( | |||
"@testonly_testing//:com_google_code_findbugs_jsr305", | |||
"@testonly_testing//:com_google_auto_value_auto_value_annotations_1_6_3", | |||
"@testonly_testing//:com_google_auto_value_auto_value_annotations", | |||
"@testonly_testing//:pin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you're right.
The formatted output is consistent with python2's
json.tool
. No changes are required to how rules_jvm_external is added in the workspace nor how :pin is run. I've tested on linux (centos) and OS X.I didn't add jq for windows because I wasn't sure if pinning worked for windows at all, and I can't test it. Should I add that as well?