Use coursier's default cache directory when fetching jars to update the install.json file #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jin
approved these changes
May 22, 2020
coursier.bzl
Outdated
|
|
||
| # locations from https://get-coursier.io/docs/1.1.0-M14-1/cache.html#default-location | ||
| if _is_windows(os_name): | ||
| return "%s\\Coursier\\Cache\\v1" % os_env.get("LOCALAPPDATA") |
There was a problem hiding this comment.
Sorry for the delay, I just managed to try this on a Windows machine.
While pinning artifacts on Windows is still pretty broken with the pin script not working properly (#324), this should be "%s/Coursier/cache/v1" % os_env.get("LOCALAPPDATA").replace("\\", "/"), based on what I've tested.
There was a problem hiding this comment.
Thanks for testing it on Windows! Is it supposed to be lower case cache in the path or captilized Cache ?
coursier.bzl
Outdated
| return location | ||
| return coursier_cache_env_var | ||
|
|
||
| # locations from https://get-coursier.io/docs/1.1.0-M14-1/cache.html#default-location |
There was a problem hiding this comment.
The current version is https://get-coursier.io/docs/2.0.0-RC5-3/cache.html#default-location
|
Thank you so much for this! Just tried it out on this repo itself, it is a big speedup. |
…he install.json file
cheister
force-pushed
the
use-coursier-cache-when-generating-install-json-file
branch
from
4e47cd3
to
3118e15
Compare
jin
approved these changes
May 23, 2020
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I run
bazel run @unpinned_maven//:pinit downloads every jar defined in themaven_installtarget because the @unpinned_maven repository is deleted every time it is "fetched". Basically the Coursier cache used for fetching atexternal/unpinned_maven/v1is never re-used when you are updating themaven_install.jsonfile.This PR changes the unpinned fetch so it uses Coursier's default cache locations or the COURSIER_CACHE env var for the cache.
By re-using the cache a
bazel run @unpinned_maven//:pinupdate now takes around 60 seconds instead of 10-15 minutes when the cache is empty.