Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for bug in artifacts that use version intervals for deps #446

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Add regression test for bug in artifacts that use version intervals for deps #446

merged 1 commit into from
Dec 1, 2020

Conversation

jin
Copy link
Member

@jin jin commented Aug 14, 2020 •
edited
Loading

2.0.0-RC6-24 (and now 2.0.7 on RJE HEAD) brings bugfixes to artifacts that use version intervals in their deps, and add regression tests to fix #433.

See coursier/coursier#1792 and #433

@jin jin changed the title Update Coursier to 2.0.0-RC6-24 Update Coursier to 2.0.0-RC6-24, and fix bug in artifacts that use version intervals for deps Aug 14, 2020
@jin
Copy link
Member Author

jin commented Aug 14, 2020

cc @friendly-pineapple

@jin jin marked this pull request as ready for review August 14, 2020 11:29
@jin jin requested a review from c-parsons as a code owner August 14, 2020 11:29
@jin jin requested a review from shs96c August 14, 2020 11:29
@jin
Copy link
Member Author

jin commented Aug 14, 2020 •
edited
Loading

It looks like 2.0.0-RC6-24 is having some problems running on Windows. Unfortunately I don't have immediate access to a Windows machine :(

@aman-harness
Copy link

Hey @jin Is there a timeline for this to go live? We are also blocked on this. Thanks.

@EArbeitman
Copy link

Hey @jin any updates on when this will be merged?

shs96c
shs96c approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@friendly-pineapple
Copy link

Aloha, wanted to ping in here and ask if there's any updates on this PR. By the way, I saw that most of the test errors are the result of Unable to run coursier: Timed out -- is this a transient issue that can simply be retried?

@jin jin mentioned this pull request Nov 30, 2020
Merged
@jin jin changed the title Update Coursier to 2.0.0-RC6-24, and fix bug in artifacts that use version intervals for deps Add regression test for bug in artifacts that use version intervals for deps Nov 30, 2020
@jin jin requested a review from cheister November 30, 2020 08:10
@jin
Copy link
Member Author

jin commented Nov 30, 2020

@cheister managed to update Coursier to 2.0.7 and fix running it on Windows! I rebased this PR so that it's only adding a regression test to assert that the bug has been fixed.

@jin jin merged commit 6584693 into bazelbuild:master Dec 1, 2020
@friendly-pineapple
Copy link

Amazing!!! When could we roughly expect a new tag cut for rules_jvm_external?

@jin jin mentioned this pull request Jan 6, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

@c-parsons c-parsons Awaiting requested review from c-parsons

@cheister cheister Awaiting requested review from cheister cheister is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependencies in generated jvm_import rules leads to runtime exceptions
6 participants
@jin @aman-harness @EArbeitman @friendly-pineapple @shs96c @googlebot