Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a deps and a setup macro #481

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Introduce a deps and a setup macro #481

merged 3 commits into from
Nov 18, 2020

Conversation

shs96c
Copy link
Collaborator

@shs96c shs96c commented Nov 13, 2020

This allows us to pull in dependencies that we may need to ensure that
rules_jvm_external functions. At present, we use this to make sure we
use rules_java for our own java targets.

@jin
Copy link
Member

jin commented Nov 14, 2020

It looks like the @rules_java load requirement is put on hold, so I don't think it's necessary to introduce that to this project now: bazelbuild/bazel#8746 (comment)

We should still have the scaffolding, maybe we could use this PR to build Hasher and MergeJars from source, instead of relying on a deploy jar?

@shs96c
Copy link
Collaborator Author

shs96c commented Nov 14, 2020 via email

@jin
Copy link
Member

jin commented Nov 16, 2020

I'd prefer to add a load dependency if we don't need to, and it's not clear what the plan is for enforcing @rules_java. Certainly not happening in Bazel 4.0, from release notes.

We can add the scaffolding for deps and setup in this PR, and follow up with a PR to build those binaries from source.

@jin
Copy link
Member

jin commented Nov 18, 2020

Discussion about loading rules_java on bazel-discuss today: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/bazel-discuss/XNvpWcge4AE/dVPDrQDhBQAJ

repositories.bzl Outdated Show resolved Hide resolved
This allows us to pull in dependencies that we may need to ensure that
rules_jvm_external functions. At present, we use this to make sure we
use `rules_java` for our own java targets.
@shs96c shs96c merged commit 2e5a9c8 into bazelbuild:master Nov 18, 2020
@shs96c shs96c deleted the setup branch November 18, 2020 13:53
@jin jin mentioned this pull request Jan 6, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants