Declare COURSIER_OPTS to make it available #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option was added in bazelbuild#385 Not sure which bazel versions are strict about exposing env vars to repository rules, but it seems that with bazel 3.3.1 COURSIER_OPTS isn't propagated by default. One use-case is supporting proxy, for built-in repository rules it's possible for example to add following to .bazelrc > startup --host_jvm_args=-Dhttps.proxyHost=... --host_jvm_args=-Dhttps.proxyPort=... --host_jvm_args=-Djavax.net.ssl.trustStore=... --host_jvm_args=-Djavax.net.ssl.trustStorePassword=... Alternatively we could add TRUST_STORE and TRUST_STORE_PASSWORD env vars, but since COURSIER_OPTS is already here, let's stick with that one.
divanorama
requested review from
c-parsons,
cheister,
jin and
shs96c
as code owners
shs96c
approved these changes
Dec 22, 2020
|
Thank you for the PR. Making things easier for people seems like an excellent idea :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option was added in #385
Not sure which bazel versions are strict about exposing env vars to repository rules, but
it seems that with bazel 3.3.1 COURSIER_OPTS isn't propagated by default.
One use-case is supporting proxy, for built-in repository rules it's possible for example to add following to .bazelrc
Alternatively we could add TRUST_STORE and TRUST_STORE_PASSWORD env vars, but since COURSIER_OPTS is already here, let's stick with that one.