Make read_coordinates public #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheister
approved these changes
Feb 15, 2021
|
Should this function be moved out of the private package, then? I'd like our Starlark public API to be well-defined, at least through package location. |
shs96c
force-pushed
the
read-coordinates
branch
from
19cbd3d
to
31b9bf9
Compare
|
@jin would you like me to expose the method from |
|
Yep, just so that folks don't load symbols from |
shs96c
force-pushed
the
read-coordinates
branch
from
31b9bf9
to
b9daed8
Compare
jin
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful for other tools to be able to extract maven coordinates
from tags (for example, Selenium's Java Module generation) Making this
function public makes this possible.