Add a deploy_env attribute to java_export
#534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `java_export` to be used to generate things such as plugins for Apache Spark or jar files for use in JEE servers by excluding provided dependencies from the generated jars. This is analagous to maven's `provided` scope, and maps to the `deploy_env` attribute of `java_binary`. The difference between `java_export` and `java_binary`'s `deploy_env` is that `java_export` allows anything that provides a `JavaInfo` as an input to `deploy_env`. This is because the expected use-cases are for things that are normally provided as regular imports from a maven dependency, rather than a custom binary.
jin
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
java_exportto be used to generate things such asplugins for Apache Spark or jar files for use in JEE servers by
excluding provided dependencies from the generated jars. This is
analagous to maven's
providedscope, and maps to thedeploy_envattribute of
java_binary.The difference between
java_exportandjava_binary'sdeploy_envis that
java_exportallows anything that provides aJavaInfoas aninput to
deploy_env. This is because the expected use-cases are forthings that are normally provided as regular imports from a maven
dependency, rather than a custom binary.