Fix proxy parsing when HTTP_PROXY doesn't have a scheme (#541) #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jin
approved these changes
Mar 30, 2021
private/proxy.bzl
Outdated
| if ":" in netloc: | ||
| return netloc.split(":")[0] | ||
| else: | ||
| return netloc | ||
|
|
||
| def _get_proxy_port(url): | ||
| netloc = url.split("://", 1)[1].split("/")[0].split("@")[-1] | ||
| no_scheme_url = url.split("://", 1)[1] if "://" in url else url |
There was a problem hiding this comment.
nit: extract this line into a function?
cheister
force-pushed
the
fix-no-scheme-proxy-parsing
branch
from
31114ef
to
ff29024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for HTTP_PROXY parsing when url doesn't have a scheme #541