Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact["exclusions"] #622

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

asinbow
Copy link
Contributor

@asinbow asinbow commented Nov 22, 2021

d98ea59#r60658332

We encounter this bug when using the newest code.

ERROR: An error occurred during the fetch of repository 'unpinned_maven':
   Traceback (most recent call last):
	File "/private/var/tmp/_bazel_haowang/67362b0cd09d93b47f4dadb7394eed77/external/rules_jvm_external/coursier.bzl", line 837, column 38, in _coursier_fetch_impl
		dep_tree = make_coursier_dep_tree(
	File "/private/var/tmp/_bazel_haowang/67362b0cd09d93b47f4dadb7394eed77/external/rules_jvm_external/coursier.bzl", line 770, column 42, in make_coursier_dep_tree
		return deduplicate_and_sort_artifacts(
	File "/private/var/tmp/_bazel_haowang/67362b0cd09d93b47f4dadb7394eed77/external/rules_jvm_external/private/artifact_utilities.bzl", line 49, column 41, in deduplicate_and_sort_artifacts
		if sorted(duplicate_artifact["exclusions"]) == sorted(artifacts_with_exclusions[duplicate_coord]):
Error: key "exclusions" not found in dictionary
ERROR: key "exclusions" not found in dictionary

Not sure whether this is the best solution, please take a look.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 22, 2021
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That must have been painful to run into. Thank you for the PR!

@shs96c shs96c merged commit ac5aed3 into bazelbuild:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants