Respect NO_PROXY=.example.com #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing the `NO_PROXY` environment variable, rules_jvm_exported mapped `foo.example.com,.example.com` to the JVM's `-Dhttp.nonProxyHosts=foo.example.com|*.example.com`. However, it failed to map `.example.com` to `*.example.com`, because it only remapped subdomain expressions that followed a comma. Address this by separately handling an environment string beginning with a ".".
ghost
requested review from
c-parsons,
cheister,
jin and
shs96c
as code owners
shs96c
approved these changes
Dec 23, 2021
|
fix problem no proxy assigned same owner NextSteps79 |
Shago7927
reviewed
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing the
NO_PROXYenvironment variable,rules_jvm_exported mapped
foo.example.com,.example.comto the JVM's-Dhttp.nonProxyHosts=foo.example.com|*.example.com. However, itfailed to map
.example.comto*.example.com, because it onlyremapped subdomain expressions that followed a comma.
Address this by separately handling an environment string beginning
with a ".".
Resolves #636.