Support XDG_CACHE_HOME as used by Coursier #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coursier respects `$XDG_CACHE_HOME` as a replacement for `$HOME/.cache` outside of Windows and macOS. Resolves #638.
ghost
requested review from
c-parsons,
cheister,
jin and
shs96c
as code owners
shs96c
previously requested changes
Dec 23, 2021
cheister
approved these changes
Jan 23, 2022
jin
previously requested changes
Jan 24, 2022
There was a problem hiding this comment.
Add XDG_CACHE_HOME to the environ parameter here to ensure that the repo rule re-runs when it changes
rules_jvm_external/coursier.bzl
Line 1239 in 76b752c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coursier respects
$XDG_CACHE_HOMEas a replacement for$HOME/.cacheoutside of Windows and macOS.
Resolves #638.