Propagate bazel tags= in java_export sub-targets #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmivankov
requested review from
c-parsons,
cheister,
jin and
shs96c
as code owners
shs96c
requested changes
Jan 5, 2022
| @@ -61,15 +61,14 @@ def java_export( | |||
| and so may contain any valid parameter for that rule. | |||
| """ | |||
|
|
|||
| tags = tags + ["maven_coordinates=%s" % maven_coordinates] | |||
There was a problem hiding this comment.
Previously, both the java_library and the maven_project_jar had the maven coordinates added in their tag. With this change, only the former includes it. Please add the coordinates tag back to maven_project_jar too
There was a problem hiding this comment.
Should be fixed now
One use-case is using tags=["manual"] to exclude building of these targets by default.
dmivankov
force-pushed
the
java_export_propagate_tags
branch
from
66094ff
to
94ae06a
Compare
jin
approved these changes
Jan 6, 2022
shs96c
approved these changes
Jan 17, 2022
|
Thank you for the PR! Merging now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One use-case is using tags=["manual"] to exclude building of these targets by default.