Merge jar files without unpacking them #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to create jar files that do not unpack cleanly on a file system. For example, they can include a _file_ named `foo/bar` and another file called `foo`. Attempting to merge jars by unpacking to disk and then repacking them will fail because it's not possible to unpack cleanly. This change does everything in-memory, without needing to create intermediate temporary files.
jin
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to create jar files that do not unpack cleanly on
a file system. For example, they can include a file named
foo/barand another file calledfoo. Attempting to mergejars by unpacking to disk and then repacking them will fail
because it's not possible to unpack cleanly.
This change does everything in-memory, without needing to create
intermediate temporary files.