Allow compile jars to strip illegal automatic module names #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are plenty of jars out there that have an `Automatic-Module-Name` that isn't legal. Normally, this doesn't matter too much, but when compiling code with a modern compiler bazel will use a module path, and that cares _a lot_, causing builds to fail. To rectify this, we can pass an additional flag when creating the compile jar that will strip illegal automatic module names from the generated manifests.
|
Do you mind adding an example error to the description when this isn't fixed? I'm curious what the problems actually look like. |
cheister
reviewed
Mar 18, 2022
| manifest.getMainAttributes().put(new Attributes.Name("Created-By"), "AddJarManifestEntry"); | ||
| toAdd.forEach(manifestEntry -> { | ||
| String[] manifestEntryParts = manifestEntry.split(":", 2); | ||
| manifest.getMainAttributes().put(new Attributes.Name(manifestEntryParts[0]), manifestEntryParts[1]); | ||
| }); | ||
| toRemove.forEach(name -> manifest.getMainAttributes().remove(new Attributes.Name(name))); | ||
|
|
||
| if (!makeSafe) { |
There was a problem hiding this comment.
Why not if (makeSafe) { checkAutomaticModuleName(jar, manifest); } ?
cheister
approved these changes
Mar 18, 2022
jin
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are plenty of jars out there that have an
Automatic-Module-Namethat isn't legal. Normally, this doesn't matter too much, but when
compiling code with a modern compiler bazel will use a module path,
and that cares a lot, causing builds to fail.
To rectify this, we can pass an additional flag when creating the
compile jar that will strip illegal automatic module names from the
generated manifests.