Fix the Boringssl static dependency loop #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to the external targets. (bazelbuild#5) * For an external publishing tool, making the maven_publish rule (and the ""<name>.publish" target) visible to the external targets. This allows capturing the list of files (artifact, source, doc, pom) for an external publishing tool to known about, reason about, and correctly process these artifacts as needed. * Add a provider to export the information being published. Make the provider available to the external users.
…nal dependency loop This is a test which demonstrates the problem.
tjoneslo
requested review from
jin,
c-parsons,
shs96c and
cheister
as code owners
This was referenced Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue
Check for the specific failure case seen by the netty-tcnative-boringssl-static library by identifying the specific problem as seen and skipping the dependency loop generation in the
BUILDfile generation. This may be too fragile, but does address the problem.