Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass downloaded_file_path to http_file #702

Merged

Conversation

Bencodes
Copy link
Contributor

@Bencodes Bencodes commented May 26, 2022

Ensures that the correct file extensions exist on the files being downloaded

#684

@Bencodes Bencodes requested a review from cheister as a code owner May 26, 2022 00:11
Copy link
Member

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding some tests, specifically using the failure mode in the linked issue?

@Bencodes
Copy link
Contributor Author

@jin updated!

@jin jin merged commit 94ac7bf into bazelbuild:master May 26, 2022
@jin
Copy link
Member

jin commented May 26, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants