Generate both a BOM and a dependency BOM #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how we generate BOMs to something that is more often seen "in the wild". The main BOM now contains just a list of all the `java_export` targets that are listed in the `java_exports` parameter. If the `dependencies_maven_coordinates` parameter is set, then we shall also generate a "dependencies" BOM, which lists all the first-order deps of the `java_exports` as well as having a reference to the parent BOM. Each of these are ultimately a `pom.xml` file, and each of these is generated using its own rule.
jin
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we generate BOMs to something that is more often seen "in the wild". The main BOM now contains just a list of all the
java_exporttargets that are listed in thejava_exportsparameter.If the
dependencies_maven_coordinatesparameter is set, then we shall also generate a "dependencies" BOM, which lists all the first-order deps of thejava_exportsas well as having a reference to the parent BOM.Each of these are ultimately a
pom.xmlfile, and each of these is generated using its own rule.