Remove the unsafe_shared_cache option
#834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheister
approved these changes
Jan 17, 2023
|
Looks like the tests still reference |
jin
approved these changes
Jan 18, 2023
This feature wasn't being tested properly, so we had no way of determining whether it would work. For the case of pinning artifacts (which is the recommended approach) it's possible to use the `COURSIER_CACHE` env var to still use the shared cache.
shs96c
force-pushed
the
remove-shared-cache
branch
from
0ed2b09
to
5700161
Compare
lukaciko
added a commit
to lukaciko/rules_jvm_external
that referenced
this pull request
Apr 6, 2023
The test using the file was removed in bazelbuild#834.
shs96c
pushed a commit
that referenced
this pull request
Apr 12, 2023
The test using the file was removed in #834.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature wasn't being tested properly, so we had no way of determining whether it would work. For the case of pinning artifacts (which is the recommended approach) it's possible to use the
COURSIER_CACHEenv var to still use the shared cache.