-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to pass args to MavenPublisher #937
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed CLA |
Do I need to do something additional to get this reviewed? I don't anticipate getting it accepted immediately, but I was hoping to start a conversation around this PR. Is the CLA check causing people not to review it? I believe I've signed it, just wanted to make sure I'm moving the ball forward. |
Sorry for the delay getting back to you. I was on vacation for a while. Reviewing now! |
f94c554
to
4faeffa
Compare
4faeffa
to
36c351e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your patience and understanding!
This is an attempt to address #936