Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to pass args to MavenPublisher #937

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

loganasherjones
Copy link
Contributor

This is an attempt to address #936

@google-cla
Copy link

google-cla bot commented Jul 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@loganasherjones
Copy link
Contributor Author

Signed CLA

@loganasherjones
Copy link
Contributor Author

Do I need to do something additional to get this reviewed? I don't anticipate getting it accepted immediately, but I was hoping to start a conversation around this PR.

Is the CLA check causing people not to review it? I believe I've signed it, just wanted to make sure I'm moving the ball forward.

@shs96c
Copy link
Collaborator

shs96c commented Aug 17, 2023

Sorry for the delay getting back to you. I was on vacation for a while. Reviewing now!

private/rules/maven_publish.bzl Outdated Show resolved Hide resolved
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your patience and understanding!

@shs96c shs96c merged commit 12df2da into bazelbuild:master Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants