Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest rules_kotlin #947

Closed
wants to merge 3 commits into from
Closed

Conversation

sgowroji
Copy link
Member

Fixes #946

@shs96c
Copy link
Collaborator

shs96c commented Aug 30, 2023

Thank you for the PR. Updating to the latest release would be great.

It looks like there are genuine failures with this PR:

tests/bazel_run_tests.sh
--
  | ERROR: Traceback (most recent call last):
  | File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/io_bazel_rules_kotlin/kotlin/internal/defs.bzl", line 23, column 25, in <toplevel>
  | JavaPluginInfo = getattr(java_common, "JavaPluginInfo")
  | Error in getattr: 'java_common' value has no field or method 'JavaPluginInfo'
  | ERROR: error loading package '': in /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/io_bazel_rules_kotlin/kotlin/repositories.bzl: in /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/io_bazel_rules_kotlin/src/main/starlark/core/repositories/initialize.bzl: Extension file 'kotlin/internal/defs.bzl' has errors
  | INFO: Elapsed time: 2.154s
  | INFO: 0 processes.

from here

@sgowroji
Copy link
Member Author

Closing this one. I will update once after getting complete information.

@sgowroji sgowroji closed this Aug 30, 2023
@sgowroji sgowroji reopened this Sep 8, 2023
@sgowroji
Copy link
Member Author

sgowroji commented Sep 8, 2023

@hvadehra Could you please guide on the failures. Thanks!

@hvadehra
Copy link
Member

hvadehra commented Sep 8, 2023

The failure linked above is for builds using Bazel 4.x. which presumably the kotlin rules no longer support. The bazel team itself is dropping support for v4 in a few months: https://bazel.build/release#support-matrix

The failure for bazel 5.0 is a little surprising, looking into it now.

@hvadehra
Copy link
Member

hvadehra commented Sep 8, 2023

Okay, so I can reproduce the failure for 5.0.0 locally, but tests pass with 5.4.1 which is the version everyone on 5.x should be using.

@shs96c
Copy link
Collaborator

shs96c commented Sep 8, 2023

@jin, do you think it's fine for us to require the last 5.x release? Or should we hold off on this?

@jin
Copy link
Member

jin commented Sep 11, 2023

If Bazel 4's going to be EOL soon, I think it's reasonable to start requiring 5.X for the next RJE release.

@meteorcloudy
Copy link
Member

@shs96c Can you draft a proper change to drop Bazel 4 support?

@sgowroji
Copy link
Member Author

sgowroji commented Oct 6, 2023

Closing this PR as this doesn't fix the above issue. Thanks.

@sgowroji sgowroji closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: 'JavaInfo' value has no field or method 'transitive_deps'
5 participants