-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest rules_kotlin #947
Conversation
Thank you for the PR. Updating to the latest release would be great. It looks like there are genuine failures with this PR: tests/bazel_run_tests.sh
--
| ERROR: Traceback (most recent call last):
| File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/io_bazel_rules_kotlin/kotlin/internal/defs.bzl", line 23, column 25, in <toplevel>
| JavaPluginInfo = getattr(java_common, "JavaPluginInfo")
| Error in getattr: 'java_common' value has no field or method 'JavaPluginInfo'
| ERROR: error loading package '': in /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/io_bazel_rules_kotlin/kotlin/repositories.bzl: in /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/io_bazel_rules_kotlin/src/main/starlark/core/repositories/initialize.bzl: Extension file 'kotlin/internal/defs.bzl' has errors
| INFO: Elapsed time: 2.154s
| INFO: 0 processes. from here |
Closing this one. I will update once after getting complete information. |
@hvadehra Could you please guide on the failures. Thanks! |
The failure linked above is for builds using Bazel 4.x. which presumably the kotlin rules no longer support. The bazel team itself is dropping support for v4 in a few months: https://bazel.build/release#support-matrix The failure for bazel 5.0 is a little surprising, looking into it now. |
Okay, so I can reproduce the failure for 5.0.0 locally, but tests pass with 5.4.1 which is the version everyone on 5.x should be using. |
@jin, do you think it's fine for us to require the last 5.x release? Or should we hold off on this? |
If Bazel 4's going to be EOL soon, I think it's reasonable to start requiring 5.X for the next RJE release. |
@shs96c Can you draft a proper change to drop Bazel 4 support? |
Closing this PR as this doesn't fix the above issue. Thanks. |
Fixes #946