java_export: Fix Make variable substitution #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
fmeum
force-pushed
the
forward-toolchains
branch
2 times, most recently
from
ae8b3bd
to
6076dba
Compare
fmeum
changed the title
|
@fmeum, I've landed your previous PR, so please feel free to rebase and continue with this if you'd like to. |
This requires forwarding `toolchains` to all rules as well as evaluating Make variables for dependency coordinates in `pom_file`.
fmeum
force-pushed
the
forward-toolchains
branch
from
6076dba
to
cf37615
Compare
|
@shs96c Thanks, this is ready now. |
|
@shs96c Friendly ping |
shs96c
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires forwarding
toolchainsto all rules as well as evaluatingMake variables for dependency coordinates in
pom_file.