-
Notifications
You must be signed in to change notification settings - Fork 136
Drop dependency on rules_docker #723
Comments
Note: I think it might be better to introduce a dep on aspect_bazel_lib instead, which is a very-well maintained utility library that's a superset of bazel_skylib, and evidently rules_docker wished for such a thing as well since it had this folder. Baby steps towards bazelbuild#723 I'd like to start small and gauge interest from rules_k8s maintainers before spending too much time here.
This is the only tricky bit of dropping rules_docker entirely Line 68 in 7fe8176
Other than that, rules_docker can be easily replaced by Translating the above into something that's compatible with However, that artifact will always follow the OCI image-spec It seems practical to teach rules_k8s resolver how to consume directory artifacts that fit that layout rather than consuming that layout in the bazel layer. Following that, the above line would translate into pointing the resolver to one or more image directories and leaving it to the go program to understand how to interpret different possible directory structures (starting with OCI image layouts to start and adding more as needed to the resolver) |
I would take care of this, but I think that the PR would never be reviewed. Unfortunately, this repository appears to be unmaintained. |
Because it is in "minimal maintenance mode"
https://github.com/bazelbuild/rules_docker#status
and also I think it's a layering violation, it shouldn't matter to rules_k8s how the images were constructed. At most, it might want to load some Provider symbols from rules_docker just to have a deeper understanding of the inputs it receives.
Related to #722
The text was updated successfully, but these errors were encountered: