Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

rules are not hermetic at all #80

Closed
ensonic opened this issue Nov 27, 2017 · 3 comments
Closed

rules are not hermetic at all #80

ensonic opened this issue Nov 27, 2017 · 3 comments

Comments

@ensonic
Copy link
Contributor

ensonic commented Nov 27, 2017

The 'run' commands for create/apply/delete shell out to kubectl and gcloud. This should maybe be mentioned at least in a README. Ideally the rules will pull the commands through the WORKSPACE for hermeticity, right?

For background when running them through dazel, one will need to installed them to the dazel docker container.

@mattmoor
Copy link
Contributor

See: #21

We don't include it because they are essentially useless without authentication configured and Bazel's current guidance on credentials is fundamentally non-hermetic.

rules_docker is more self-contained, but still needs to access credentials and binaries (e.g. credential helpers) outside the workspace to work.

@ensonic
Copy link
Contributor Author

ensonic commented Nov 28, 2017

Okay, if I send a PR that at least documents what it commands it requires?

@mattmoor
Copy link
Contributor

Absolutely :)

ensonic added a commit to ensonic/rules_k8s that referenced this issue Dec 1, 2017
This is useful to know for setting up a hermetic build environment.
See bazelbuild#80
ensonic added a commit to ensonic/rules_k8s that referenced this issue Dec 5, 2017
This is useful to know for setting up a hermetic build environment.
See bazelbuild#80
ensonic added a commit to ensonic/rules_k8s that referenced this issue Dec 13, 2017
This is useful to know for setting up a hermetic build environment.
See bazelbuild#80
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants