Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Don't dump a stack trace when we hit errors publishing images. #101

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Don't dump a stack trace when we hit errors publishing images. #101

merged 1 commit into from
Feb 7, 2018

Conversation

mattmoor
Copy link
Contributor

@mattmoor
Copy link
Contributor Author

@vaikas-google FYI

@mattmoor
Copy link
Contributor Author

@dekkagaijin FYI

@mattmoor mattmoor requested a review from dlorenc January 21, 2018 14:51
@dekkagaijin
Copy link

Looks like k8s/object.bzl needs a reformat:
https://travis-ci.org/bazelbuild/rules_k8s/builds/331471468#L647

$ buildifier -mode=check $(find . -name '*.bzl' -type f)
./k8s/object.bzl # reformat 
The command "buildifier -mode=check $(find . -name '*.bzl' -type f)" exited with 4.

@mattmoor
Copy link
Contributor Author

Yeah, that looks like a change I optimistically merged from the Bazel folks, which wasn't set up correctly to run our CI (and I figured wouldn't break our integration tests). (sigh)

This should be RFAL.

@dekkagaijin
Copy link

Radio-Frequency Assisted Liposuction (RFAL)
Fancy :o

@mattmoor
Copy link
Contributor Author

mattmoor commented Feb 7, 2018

Bump

@mattmoor mattmoor merged commit bdaddd1 into master Feb 7, 2018
@nlopezgi nlopezgi deleted the better-publish-errors branch November 27, 2018 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattmoor @dekkagaijin @dlorenc