This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Expand make vars for cluster name #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
mattmoor
reviewed
Feb 6, 2018
| @@ -136,12 +136,14 @@ def _common_impl(ctx): | |||
| files = [ctx.executable.resolver] | |||
|
|
|||
| cluster_arg = ctx.attr.cluster | |||
| cluster_arg = ctx.expand_make_variables("cluster", cluster_arg, {}) | |||
There was a problem hiding this comment.
For the sake of completeness, can you add this for namespace and image_chroot as well? (any anything else I might be forgetting).
|
FYI the process for this (since Travis won't give secrets to PRs from other repos) is that once reviewed I'll merge this into a branch and open a second PR to make sure we don't break the integration tests. This is awesome, thanks again. |
|
Just added |
mattmoor
approved these changes
Feb 6, 2018
|
@bazel-io Test this please |
mattmoor
pushed a commit
that referenced
this pull request
Feb 7, 2018
* implemented make vars expansion * added make vars expansion for namespace and image_chroot * Fix buildifier issues
mattmoor
added a commit
that referenced
this pull request
Feb 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to propose a fix to #77