Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Properly support multi-document yaml files. #117

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Properly support multi-document yaml files. #117

merged 1 commit into from
Mar 1, 2018

Conversation

mattmoor
Copy link
Contributor

Fixes: #116

@mattmoor
Copy link
Contributor Author

@philwo Is CI not set up for this repo?

@mattmoor mattmoor force-pushed the fix-yaml branch 2 times, most recently from bbbf6db to 48c026a Compare February 28, 2018 15:08
@mattmoor
Copy link
Contributor Author

@pcj FYI

@mattmoor mattmoor force-pushed the fix-yaml branch 2 times, most recently from 895ffee to ef1434f Compare February 28, 2018 15:42
@philwo
Copy link
Member

philwo commented Feb 28, 2018

Post- and presubmit checks should now be working for this repo! Please let me know if you encounter any issues.

@mattmoor
Copy link
Contributor Author

@philwo Updating the commit doesn't seem to have made this register with buildkite?

@buchgr
Copy link
Contributor

buchgr commented Feb 28, 2018

@mattmoor fixed. should work now

@mattmoor
Copy link
Contributor Author

@buchgr Why doesn't this show up the same way it does in `rules_docker?

@buchgr
Copy link
Contributor

buchgr commented Feb 28, 2018

@mattmoor it will in the next build. you can test it out by just changing the commit hash in this PR (git commit --amend or so).

@mattmoor
Copy link
Contributor Author

mattmoor commented Mar 1, 2018

FYI, I'm going to ignore the CI failure (I/O failure) since macOS doesn't provide super meaningful coverage for rules_k8s and I've shared this with the Bazel team as an example of poor contributor UX.

@mattmoor mattmoor merged commit 3a90662 into master Mar 1, 2018
@mattmoor mattmoor deleted the fix-yaml branch March 1, 2018 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants