Propagate implicitly added attributes/arguments to instantiated rules #137
Conversation
ash2k
force-pushed
the
propagate-tags
branch
2 times, most recently
from
6bc67c1
to
d0c6f6c
Compare
|
ping @mattmoor |
|
can you add visibility too, as we just discussed on slack? |
k8s/object.bzl
Outdated
| @@ -399,24 +399,26 @@ def k8s_object(name, **kwargs): | |||
| kwargs["image_targets"] = _deduplicate(kwargs.get("images", {}).values()) | |||
| kwargs["image_target_strings"] = _deduplicate(kwargs.get("images", {}).values()) | |||
|
|
|||
| tags = kwargs.get("tags", None) | |||
There was a problem hiding this comment.
From https://docs.bazel.build/versions/master/skylark/lib/globals.html#rule,
Attributes
visibility,deprecation,tags,testonly, andfeaturesare implicitly added and cannot be overridden.
Maybe we should have an implicit_attrs dict listing all of these attrs, and pass that as kwargs to the instantiated rules?
|
I've made the requested changes but I don't know how to test it and I also don't have much time for it, sorry. |
|
The build is stuck |
|
cc @erain this PR would be good low-risk practice for how we test PRs in this repo (b/c secrets are hard). This is going to be easiest if I walk you through it end-to-end over GVC. |
ash2k
changed the title
|
What's blocking the merge? |
|
Sorry @mattmoor I missed this PR and the conversation. I will take the next chance to learn from the PR tests. |
Fixes #123.