Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Create root-level OWNERS file #153

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Create root-level OWNERS file #153

merged 2 commits into from
Jun 28, 2018

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Jun 28, 2018

/assign @erain

After this /approve should work as expected.

Do we want to enable blunderbuss to have prow automatically assign a reviewer on new PRs?

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @fejta. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@erain erain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "automatically assign a reviewer" is a good idea!

And I would suggest to expand the reviewers pool so we can all ramp up quickly.

OWNERS Outdated
@@ -0,0 +1,13 @@
# See Config struct in https://github.com/kubernetes/test-infra/blob/master/prow/repoowners/repoowners.go

reviewers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add both Nick and Xin as reviewers as well?

+- nlopezgi
+- xingao267

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just add nlopezgi (we'll add xingao267 later)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, once this is in I'll send a PR to turn on blunderbuss.

OWNERS Outdated
@@ -0,0 +1,13 @@
# See Config struct in https://github.com/kubernetes/test-infra/blob/master/prow/repoowners/repoowners.go

reviewers:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@fejta fejta merged commit 91b6cfe into bazelbuild:master Jun 28, 2018
@fejta fejta deleted the own branch June 28, 2018 21:15
@fejta
Copy link
Contributor Author

fejta commented Jun 28, 2018

The travis CI failure is expected because my PR uses my fork

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants