-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @fejta. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "automatically assign a reviewer" is a good idea!
And I would suggest to expand the reviewers pool so we can all ramp up quickly.
OWNERS
Outdated
@@ -0,0 +1,13 @@ | |||
# See Config struct in https://github.com/kubernetes/test-infra/blob/master/prow/repoowners/repoowners.go | |||
|
|||
reviewers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add both Nick and Xin as reviewers as well?
+- nlopezgi
+- xingao267
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just add nlopezgi (we'll add xingao267 later)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, once this is in I'll send a PR to turn on blunderbuss.
OWNERS
Outdated
@@ -0,0 +1,13 @@ | |||
# See Config struct in https://github.com/kubernetes/test-infra/blob/master/prow/repoowners/repoowners.go | |||
|
|||
reviewers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
The travis CI failure is expected because my PR uses my fork |
/assign @erain
After this
/approve
should work as expected.Do we want to enable blunderbuss to have prow automatically assign a reviewer on new PRs?