Add resolver to k8s_defaults

[samschlegel]

This adds support for setting the default resolver with the k8s_defaults rule

[chrislovecnm]

/ok-to-test

[chrislovecnm]

Do we need to update the docs and can we add a test for this?

[chrislovecnm]

Thanks for the PR!!! Appreciate your help.

[chrislovecnm]

This failed in e2e, and I am not certain why.

customresourcedefinition.apiextensions.k8s.io "todos.rules-k8s.bazel.io" deleted
Error from server: grpc: the client connection is closing

@samschlegel e2e failed, so I am rerunning it.

[chrislovecnm]

/test pull-rules-k8s-e2e

[chrislovecnm]

@nlopezgi any idea why the other bazel builds are not running??

[chrislovecnm]

Passing CI now. Documentation and tests are the only thing we need 😊

[nlopezgi]

Writing tests for this might be hard as these are workspace repo rules being changed, but lets just double check documentation is up to date and this should be good to submit imo

[fejta]

Writing tests for this might be hard

https://github.com/bazelbuild/rules_k8s/blob/master/examples/hellogrpc/BUILD#L20 etc use k8s_defaults rules... we could just put something to resolve in one of them, and ensure e2e tests continue passing

[chrislovecnm]

Because tests are hard we can do another PR, but frankly we need a lot more tests 😞

[chrislovecnm]

Can you rebase and do we need any doc changes?

Thanks for your help!

[chrislovecnm]

@nlopezgi do we need docs update on this??

[samschlegel]

Apologies, I didn't see the updates to this. Let me know if there's anything I need to do

[chrislovecnm]

@samschlegel do we need any doc updates?

@nlopezgi can you start build kite CI?

/ok-to-test

[samschlegel]

No doc updates are needed, as this is actually already in the docs as being supported 😅

[chrislovecnm]

Need CI to pass and we can merge this

[nlopezgi]

kicked off presubmits, this PR looks good other than the missing doc updates.

[samschlegel]

AFAICT no doc updates are needed as this was (erroneously?) added to docs in dc3999f

EDIT: Can add to the k8s_object/k8s_objects docs since I think that's what dc3999f meant to do

[nlopezgi]

ugh, mac builds are timing out pulling images, will have to figure out tomorrow what's the problem

[chrislovecnm]

@nlooezgi can you get this to retest?

[chrislovecnm]

We need another rebase.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, fejta, samschlegel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment