Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Propagate arguments for implicit attributes to instantiated rules #204

Merged
merged 5 commits into from
Oct 26, 2018

Conversation

Globegitter
Copy link
Contributor

This replaces #165 adds some examples as @fejta requested. The build would fail on master but is working on this branch.

Let me know if that is sufficient enough.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@Globegitter
Copy link
Contributor Author

@ash2k Could you approve the cla please?

@ash2k
Copy link

ash2k commented Oct 24, 2018

@Globegitter Something's not right with the bot - see #143 (comment)

@nlopezgi
Copy link
Contributor

Thanks for putting this together @Globegitter
ugh, the bot sometimes misbehaves with the CLA, but that's not a big issue, we just need you to confirm explicitly in the comments you accept the CLA and I can override the check. Kicked off buildkite tests, will review PR in detail tomorrow.

@Globegitter
Copy link
Contributor Author

@nlopezgi I confirm the CLA.

Is that ok?

@nlopezgi
Copy link
Contributor

/ok-to-test

@nlopezgi
Copy link
Contributor

@Globegitter yes, that is OK, thanks!

@nlopezgi
Copy link
Contributor

/retest

@nlopezgi
Copy link
Contributor

@Globegitter actually, just noticed we also need a confirmation from @ash2k here too if possible that they accept the CLA.

@nlopezgi
Copy link
Contributor

/retest

@bazelbuild bazelbuild deleted a comment from k8s-ci-robot Oct 25, 2018
@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 25, 2018
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Globegitter, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi
Copy link
Contributor

/retest

@nlopezgi
Copy link
Contributor

thanks @Globegitter this PR is ready to be squashed, all I need is confirmation from @ash2k for the CLA and then I can merge

@ash2k
Copy link

ash2k commented Oct 25, 2018

I confirm the CLA.

@Globegitter thanks for picking it up.

@nlopezgi
Copy link
Contributor

/override cla/google

@k8s-ci-robot
Copy link

@nlopezgi: Overrode contexts on behalf of nlopezgi: cla/google

In response to this:

/override cla/google

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nlopezgi
Copy link
Contributor

cla overridden with written approval from authors in comments above

@nlopezgi
Copy link
Contributor

/retest

@nlopezgi nlopezgi merged commit 92b56b5 into bazelbuild:master Oct 26, 2018
@Globegitter Globegitter deleted the propogate-tags3 branch October 26, 2018 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants