kubectl via toolchains (continued) #212
Conversation
…ects the cubectl path.
|
/uncc |
|
/retest |
|
/retest |
…oolchain target. Undoing deletion of the static kubectl toolchain rule for internal use.
k8s/kubectl_configure.bzl
Outdated
| @@ -0,0 +1,31 @@ | |||
| # Copyright 2018 The Bazel Authors. All rights reserved. | |||
There was a problem hiding this comment.
lets move this file to toolchains/kubectl so the reference to :BUILD.tpl can be relative
There was a problem hiding this comment.
Moved kubectl_configure.bzl to toolchains/kubectl.
But the reference to BUILD.tpl still has to be absolute. If (in repository_ctx.template) a string or a path object is used to specify the template file, then it will be relative to the local_k8s_config repo. If a Label is used, then an absolute path must be specified.
…s into kubectl-via-toolchains
|
From my understanding, the fix to #215 will just remove the exec_compatible_with attribute from the three toolchain targets that are in //toolchains/kubectl/BUILD. I did this change locally and run the e2e test successfully. But will definitely look into the PR that will follow. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alex1545, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Tests don't actually run in parallel yet because the prow job parallelism limit is still set to 1 |
|
Opened #219 to disable the flakiest test |
|
New changes are detected. LGTM label has been removed. |
WORKSPACE rule to configure the kubectl tool. For now it onle autodetects the cubectl path.