This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Update toolchain docs #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 26, 2018 16:55
* also provide a better error message if no kubectl tool is found locally
smukherj1
approved these changes
Nov 27, 2018
| ) | ||
| # Register the default kubectl toolchain targets for supported platforms | ||
| # note these work with the autoconfigured toolchain | ||
| native.register_toolchains( |
There was a problem hiding this comment.
Wondering if we should move the toolchain registration to be under the "k8s_config" if condition as well? Allows users to decide their own toolchain registration priority order when defining their own toolchain configuration
There was a problem hiding this comment.
i think it makes sense, will do in an upcoming PR
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel runfor a target that requires the toolchain is configured#234