Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

use latest release of protobuf #243

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Conversation

nlopezgi
Copy link
Contributor

fixes #240

@nlopezgi nlopezgi requested review from smukherj1 and xingao267 and removed request for smukherj1 December 10, 2018 15:23
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, nlopezgi, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrislovecnm
Copy link
Contributor

/lgtm

@nlopezgi
Copy link
Contributor Author

/retest

@nlopezgi nlopezgi merged commit 7269a70 into bazelbuild:master Dec 11, 2018
@meteorcloudy
Copy link
Member

https://buildkite.com/bazel/rules-k8s-k8s/builds/426#e73ed2f0-2a3b-4163-ada9-f4c59292ff12

ERROR: /Users/buildkite/builds/buildkite-imacpro-9/bazel/rules-k8s-k8s/examples/hellogrpc/java/server/BUILD:20:1: no such package '@java_image_base//image': Pull command failed: F1213 10:36:50.939079   86586 __main__.py:127] Error pulling and saving image gcr.io/distroless/java@sha256:84740ded6cbeebaa89c9b19aed3754d464586592b561e5494be4192ac0b3a8f5: [Errno 54] Connection reset by peer
--
  | (/usr/bin/python /private/var/tmp/_bazel_buildkite/73fdb406995ac6797cdaa636ec7f1539/external/puller/file/downloaded --directory /private/var/tmp/_bazel_buildkite/73fdb406995ac6797cdaa636ec7f1539/external/java_image_base/image --name gcr.io/distroless/java@sha256:84740ded6cbeebaa89c9b19aed3754d464586592b561e5494be4192ac0b3a8f5) and referenced by '//examples/hellogrpc/java/server:server'
  | ERROR: /Users/buildkite/builds/buildkite-imacpro-9/bazel/rules-k8s-k8s/examples/hellohttp/java/BUILD:20:1: no such package '@jetty_image_base//image': Pull command failed: Timed out (/usr/bin/python /private/var/tmp/_bazel_buildkite/73fdb406995ac6797cdaa636ec7f1539/external/puller/file/downloaded --directory /private/var/tmp/_bazel_buildkite/73fdb406995ac6797cdaa636ec7f1539/external/jetty_image_base/image --name gcr.io/distroless/java/jetty@sha256:c5bba383c4a37fbb316d1627af172703aa10ed39f9652de56c6a5e87bacc2d66) and referenced by '//examples/hellohttp/java:server'

rules_k8 is failing on mac, is this a valid failure or just a flake?

@nlopezgi
Copy link
Contributor Author

nlopezgi commented Dec 13, 2018

mac has been super flaky for us pulling images (both this repo and rules_docker). I sent an email some days ago internally asking for advice but got no response yet. Can we turn off just mac checks for now in Bazel Ci while I figure out out?

@meteorcloudy
Copy link
Member

In that case, I think it's fine to turn off mac for rules_docker and rules_k8s for now.

@nlopezgi
Copy link
Contributor Author

thanks!

@chrislovecnm
Copy link
Contributor

@nlopezgi have we filed a bug with buildkite?

@meteorcloudy
Copy link
Member

To disable mac, you can just comment out the mac config in this file: https://github.com/bazelbuild/rules_k8s/blob/master/.bazelci/presubmit.yml#L13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update your protobuf dependency to version 3.6.1.2
5 participants