-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
https://buildkite.com/bazel/rules-k8s-k8s/builds/426#e73ed2f0-2a3b-4163-ada9-f4c59292ff12
rules_k8 is failing on mac, is this a valid failure or just a flake? |
mac has been super flaky for us pulling images (both this repo and rules_docker). I sent an email some days ago internally asking for advice but got no response yet. Can we turn off just mac checks for now in Bazel Ci while I figure out out? |
In that case, I think it's fine to turn off mac for rules_docker and rules_k8s for now. |
thanks! |
@nlopezgi have we filed a bug with buildkite? |
To disable mac, you can just comment out the mac config in this file: https://github.com/bazelbuild/rules_k8s/blob/master/.bazelci/presubmit.yml#L13 |
fixes #240