Documentation & refactoring for custom kubectl from source #251
Conversation
toolchains/kubectl/README.md
Outdated
| If no `kubectl` tool is found, trying to execute `bazel run` for any targets | ||
| will not work. | ||
| By default, the kubectl sources pulled in is defined [here](defaults.bzl). | ||
| However, if you wanted to use release v1.13.1, call `kubectl_configure` as |
There was a problem hiding this comment.
to use e.g., release v1.13.1
| _k8s_repo_tools_commit | ||
| ), | ||
| urls = ["https://github.com/{}/{}/archive/{}.tar.gz".format( | ||
| _k8s_org, |
There was a problem hiding this comment.
lets enable overriding these values as well
|
@nlopezgi Unfortunately, with v1.10.0 I get Seems to be because https://github.com/kubernetes/kubernetes/blob/fc32d2f3698e36b93322a3465f63a14e9f0eaead/vendor/k8s.io/apimachinery points to an invalid target? Verified it works with v1.13.1 though. Addressed other comments. ptal |
| Note that by default the `k8s_repositories()` calls `kubectl_configure` if it | ||
| hasn't already been called. This configures a `kubectl_toolchain` that looks for | ||
| the `kubectl` tool in the sytem path. If no `kubectl` tool is found, trying to | ||
| execute `bazel run` for any targets will not work. |
There was a problem hiding this comment.
Also add note user must find out the right version of repository infrastructure tools that works with the version of kubectl sources they want to use by looking at the io_kubernetes_build target in https://github.com/kubernetes/kubernetes/blob/{k8s_commit}/build/root/WORKSPACE
|
@nlopezgi Doc added. ptal |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addresses #245