This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Fix --incompatible_disallow_dict_plus #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated a few repositories to pull in fixes to other incompatible changes that haven't been enabled by default in Bazel yet. More work is needed in rules_grpc and com_google_protobuf. See bazelbuild#248
smukherj1
requested review from
alex1545,
chrislovecnm,
erain and
xingao267
as code owners
|
I think the Bazel version being used by prow might be too old |
nlopezgi
reviewed
Feb 22, 2019
smukherj1
added a commit
to smukherj1/test-infra
that referenced
this pull request
Feb 22, 2019
|
/retest |
nlopezgi
approved these changes
Feb 22, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated a few repositories to pull in fixes to other incompatible
changes that haven't been enabled by default in Bazel yet. More work is
needed in rules_grpc and com_google_protobuf. See #248