images is not required on k8s_object

[jazzdan]

Unless I'm misunderstanding the meaning of required here? Let me know what you think!

[k8s-ci-robot]

Hi @jazzdan. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[erain]

/ok-to-test

You are right images is only required for some k8s resources, e.g. deployment or pod. But it is quite common though to have rules_docker to build an image and rules_k8s to deploy an image.

Could you help also double check the rule implementation if the attribute is set as required in the code?

[chrislovecnm]

/test pull-rules-k8s-e2e

[jazzdan]

Hi @erain, that's great context I wasn't aware of. I'm using this on a deployment with no images so that I can generate YAML without building an image and it seems to work just fine.

I'm not really bazel fluent (just started learning it last week) but from my reading of the code it looks to me like images is always optional?

[smukherj1]

The images attribute is not mandatory as per the declaration here.

That being said, this is blocked because our CI seems to have an issue as explained here. I'm going to try and workaround this flake to unblock this PR

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jazzdan, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [smukherj1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment