Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Increase wait for hellohttp load balancer service to come up #297

Merged
merged 6 commits into from
Mar 27, 2019

Conversation

smukherj1
Copy link
Contributor

No description provided.

@smukherj1
Copy link
Contributor Author

Well seems like waiting doesn't help

@smukherj1
Copy link
Contributor Author

smukherj1 commented Mar 26, 2019

Ok I think I see the issue. We are fetching the cluster IP in the hellohttp e2e test whereas we should be fetching the external endpoint IP

EDIT: Never mind. I realized later I was running the tests wrong locally. However, the external endpoint link did work for me when I tried it. Not sure why curl is having trouble when running on prow

@smukherj1
Copy link
Contributor Author

/retest

1 similar comment
@smukherj1
Copy link
Contributor Author

/retest

@smukherj1
Copy link
Contributor Author

Looks like there's an issue with the hellohttp python server image. I tried to run it locally and I get:

suvanjan@suvanjan:~/repos/gob/toolchain/kokoro/generator$ docker run -p 8080:8080 us.gcr.io/rules_k8s/prow/hello-http-image@sha256:13f60aa810e954c5039fdb24313dfbcdceb9883b72c8c2677d86957a2313021f
 * Running on http://0.0.0.0:8080/ (Press CTRL+C to quit)
 * Restarting with stat
Traceback (most recent call last):
  File "/app/examples/hellohttp/py/server.binary.runfiles/io_bazel_rules_k8s/examples/hellohttp/py/server.py", line 25, in <module>
    app.run(host='0.0.0.0', port=8080, debug=True)
  File "/app/examples/hellohttp/py/server.binary.runfiles/pypi__Flask_0_12_4/flask/app.py", line 841, in run
    run_simple(host, port, self, **options)
  File "/app/examples/hellohttp/py/server.binary.runfiles/pypi__Werkzeug_0_15_1/werkzeug/serving.py", line 988, in run_simple
    run_with_reloader(inner, extra_files, reloader_interval, reloader_type)
  File "/app/examples/hellohttp/py/server.binary.runfiles/pypi__Werkzeug_0_15_1/werkzeug/_reloader.py", line 332, in run_with_reloader
    sys.exit(reloader.restart_with_reloader())
  File "/app/examples/hellohttp/py/server.binary.runfiles/pypi__Werkzeug_0_15_1/werkzeug/_reloader.py", line 176, in restart_with_reloader
    exit_code = subprocess.call(args, env=new_environ, close_fds=False)
  File "/usr/lib/python2.7/subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 390, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1024, in _execute_child
    raise child_exception
OSError: [Errno 8] Exec format error

Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrislovecnm,smukherj1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrislovecnm
Copy link
Contributor

@smukherj1 that error is from an osx binary or other os binary running inside a Linux container. Exec format == you did not compile a Linux binary

@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 27, 2019
@smukherj1
Copy link
Contributor Author

@chrislovecnm it's basically this python file.

Python file is not a compiled binary so I don't think it's a target platform issue. A stackoverflow search suggests a shebang at the beginning might help which is what I'm trying. The python file is running a flask server which reloads itself. The reloading itself is failing

@chrislovecnm
Copy link
Contributor

Interesting, the only time I have seen it is with a wrong binary format.

TIL

@smukherj1
Copy link
Contributor Author

Wow that worked O__O

@smukherj1 smukherj1 merged commit b3ceedc into bazelbuild:master Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants