-
Notifications
You must be signed in to change notification settings - Fork 136
Increase wait for hellohttp load balancer service to come up #297
Conversation
Well seems like waiting doesn't help |
Ok I think I see the issue. We are fetching the cluster IP in the hellohttp e2e test whereas we should be fetching the external endpoint IP EDIT: Never mind. I realized later I was running the tests wrong locally. However, the external endpoint link did work for me when I tried it. Not sure why curl is having trouble when running on prow |
/retest |
1 similar comment
/retest |
Looks like there's an issue with the hellohttp python server image. I tried to run it locally and I get:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@smukherj1 that error is from an osx binary or other os binary running inside a Linux container. Exec format == you did not compile a Linux binary |
New changes are detected. LGTM label has been removed. |
@chrislovecnm it's basically this python file. Python file is not a compiled binary so I don't think it's a target platform issue. A stackoverflow search suggests a shebang at the beginning might help which is what I'm trying. The python file is running a flask server which reloads itself. The reloading itself is failing |
Interesting, the only time I have seen it is with a wrong binary format. TIL |
Wow that worked O__O |
No description provided.