Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Allow kubeconfig in k8s_defaults and .delete rules #327

Merged
merged 2 commits into from May 13, 2019
Merged

Allow kubeconfig in k8s_defaults and .delete rules #327

merged 2 commits into from May 13, 2019

Conversation

steeve
Copy link
Contributor

@steeve steeve commented May 2, 2019

It is now possible to use kubeconfig in k8s_defaults, which we use with k3s internally.
In .delete rules, kubeconfig was ignored, so fix that.

@k8s-ci-robot
Copy link

Hi @steeve. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smukherj1
Copy link
Contributor

Hi @steeve, Thanks for you PR and sorry for the delayed response. Could you please add a test for this here ensuring the kubeconfig argument is validated for ".delete" in addition to ".apply". Thanks!

Signed-off-by: Steeve Morin <steeve@zen.ly>
Signed-off-by: Steeve Morin <steeve@zen.ly>
@steeve
Copy link
Contributor Author

steeve commented May 10, 2019

Sure.
Amended and rebased.

Copy link
Contributor

@smukherj1 smukherj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smukherj1, steeve

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smukherj1
Copy link
Contributor

/ok-to-test

@smukherj1 smukherj1 merged commit c599190 into bazelbuild:master May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants