This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Port internal change of marking python binary versions explicitly #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smukherj1
requested review from
alex1545,
chrislovecnm,
erain,
nlopezgi and
xingao267
as code owners
nlopezgi
reviewed
May 13, 2019
There was a problem hiding this comment.
can you also add python_version to examples/hellogrpc/py/client:client and examples/hellogrpc:deployment_test and in examples/hellohttp:staging-service as in this PR: https://github.com/bazelbuild/rules_k8s/pull/306/files
nlopezgi
approved these changes
May 13, 2019
nlopezgi
approved these changes
May 13, 2019
nlopezgi
approved these changes
May 13, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.