Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Add support for select statement for k8s_objects. #342

Merged
merged 9 commits into from
May 28, 2019

Conversation

Globegitter
Copy link
Contributor

@Globegitter Globegitter commented May 21, 2019

We are making use of --define flags to deploy targets into different environments. Right now we are making use of an alias to achieve this but it has limitations and adds code complexity that we would like to remove. Unfortunately macros can not manipulate select statements directly so I have to treat a dict as a special case. See bazelbuild/bazel#8419

@k8s-ci-robot
Copy link

Hi @Globegitter. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrislovecnm
Copy link
Contributor

/ok-to-test

Looks good, a rebase would be awesome :)

@Globegitter
Copy link
Contributor Author

@chrislovecnm rebased :)

@Globegitter
Copy link
Contributor Author

Anything still blocking this to get this merged?

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Globegitter, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi
Copy link
Contributor

apilogies for the delay, thanks for the poke

@k8s-ci-robot k8s-ci-robot merged commit 16c002a into bazelbuild:master May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants