Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Add make resolve support for images. #343

Merged
merged 7 commits into from
May 27, 2019

Conversation

Globegitter
Copy link
Contributor

@Globegitter Globegitter commented May 21, 2019

This is a need that arose internally. Let me know if you need any more information / backcground on the changes.

@k8s-ci-robot
Copy link

Hi @Globegitter. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s/object.bzl Outdated Show resolved Hide resolved
k8s/object.bzl Outdated Show resolved Hide resolved
@Globegitter
Copy link
Contributor Author

@nlopezgi Fixed :)

@chrislovecnm
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@nlopezgi nlopezgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, this looks good to merge after

k8s/object.bzl Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Globegitter, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f10e702 into bazelbuild:master May 27, 2019
@Globegitter Globegitter deleted the k8s-object-images-make branch May 27, 2019 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants