Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Update protobuf pin #357

Merged
merged 3 commits into from
Jun 14, 2019
Merged

Conversation

alex1545
Copy link
Contributor

@alex1545 alex1545 commented Jun 4, 2019

Renovate bot fails to update the protobuf dependency (#356) as it's unable to guess the new strip_prefix value.

@achew22
Copy link
Member

achew22 commented Jun 4, 2019

FYI, the RenovateBot team has been very receptive to bug reports in the past over this kind of stuff. I filed renovatebot/renovate#3888 for you to track Renovate being able to handle this correctly.

@alex1545
Copy link
Contributor Author

alex1545 commented Jun 4, 2019

Thank you very much @achew22 for your immediate interaction regarding this issue.
But I intentionally haven't filed an issue as I'm not sure how this type of scenario can be handled properly. The strip_prefix can actually be anything you want and doesn't need to be 'similar' in any way to the commit reference (commit sha or tag). So I thought that the current approach of guessing that the strip_prefix ends with the commit reference is probably good enough.

@achew22
Copy link
Member

achew22 commented Jun 4, 2019

The strip_prefix can actually be anything you want and doesn't need to be 'similar' in any way to the commit reference (commit sha or tag). So I thought that the current approach of guessing that the strip_prefix ends with the commit reference is probably good enough.

That's a good bit of clarity. Asking for the strip_prefix to be updated is a github specific thing. In the case of a commit it would be the commit hash and in the case of a tag it would be the tag name.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alex1545, erain, xingao267

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alex1545,erain,xingao267]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ec7f9ac into bazelbuild:master Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants