This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
HTTP examples #36
Merged
HTTP examples #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's an exciting error on OSX :) |
|
I am going to comment the Python example for now and link to an issue on |
|
I also created the travis load balancer, so I'm going to close and reopen to make sure Travis is passing. |
mattmoor
force-pushed
the
hello-http
branch
from
41638f7
to
aaa3276
Compare
|
Ok, this should be RFAL. Tests are now green :) |
jonjohnsonjr
approved these changes
Sep 22, 2017
examples/hellohttp/e2e-test.sh
Outdated
| for i in $RANDOM $RANDOM; do | ||
| edit "$i" | ||
| update | ||
| # Don't let K8s slowness cause flakes. |
| func main() { | ||
| http.HandleFunc("/", HelloWorld) | ||
| http.ListenAndServe(port, nil) | ||
| } |
There was a problem hiding this comment.
Nit: add newline at the end of file
|
@dlorenc If you had anything to add here I'd be happy to follow up, but otherwise I'm going to lighten your load :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the same languages, except C++
Fixes: #29