Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

This adds a very simple example of templating using rules_jsonnet. #37

Merged
merged 1 commit into from
Sep 22, 2017
Merged

This adds a very simple example of templating using rules_jsonnet. #37

merged 1 commit into from
Sep 22, 2017

Conversation

mattmoor
Copy link
Contributor

Fixes: #4

@mattmoor mattmoor force-pushed the jsonnet branch 3 times, most recently from 177c626 to 90acb62 Compare September 22, 2017 18:28
jonjohnsonjr
jonjohnsonjr reviewed Sep 22, 2017
View reviewed changes
examples/hellogrpc/deployment_test.py Outdated

class DeploymentTest(unittest.TestCase):

def test_grpc_whl(self):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mattmoor mattmoor force-pushed the jsonnet branch 2 times, most recently from 7553304 to d0f9509 Compare September 22, 2017 20:49
@mattmoor
Copy link
Contributor Author

I amended this to do jsonnet for the new hellohttp sample as well.

@mattmoor mattmoor merged commit c59b165 into master Sep 22, 2017
@nlopezgi nlopezgi deleted the jsonnet branch November 27, 2018 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattmoor @jonjohnsonjr